Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: components/offline_pages/client_policy_controller_unittest.cc

Issue 2289143005: [Offline pages] Add a builder and feature struct to policy (Closed)
Patch Set: fix compile issues in test Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/client_policy_controller_unittest.cc
diff --git a/components/offline_pages/client_policy_controller_unittest.cc b/components/offline_pages/client_policy_controller_unittest.cc
index 392b1984b84feb1c8f27deabee6ac318c31a369a..75a9921f9ddff0c185f1636132cc86ac601e5bf8 100644
--- a/components/offline_pages/client_policy_controller_unittest.cc
+++ b/components/offline_pages/client_policy_controller_unittest.cc
@@ -45,36 +45,48 @@ TEST_F(ClientPolicyControllerTest, FallbackTest) {
OfflinePageClientPolicy policy = controller()->GetPolicy(kUndefinedNamespace);
EXPECT_EQ(policy.name_space, kDefaultNamespace);
EXPECT_TRUE(isTemporary(policy));
+ EXPECT_TRUE(controller()->IsRemovedOnCacheReset(kUndefinedNamespace));
+ EXPECT_FALSE(controller()->IsSupportedByDownload(kUndefinedNamespace));
}
TEST_F(ClientPolicyControllerTest, CheckBookmarkDefined) {
OfflinePageClientPolicy policy = controller()->GetPolicy(kBookmarkNamespace);
EXPECT_EQ(policy.name_space, kBookmarkNamespace);
EXPECT_TRUE(isTemporary(policy));
+ EXPECT_TRUE(controller()->IsRemovedOnCacheReset(kBookmarkNamespace));
+ EXPECT_FALSE(controller()->IsSupportedByDownload(kBookmarkNamespace));
}
TEST_F(ClientPolicyControllerTest, CheckLastNDefined) {
OfflinePageClientPolicy policy = controller()->GetPolicy(kLastNNamespace);
EXPECT_EQ(policy.name_space, kLastNNamespace);
EXPECT_TRUE(isTemporary(policy));
+ EXPECT_TRUE(controller()->IsRemovedOnCacheReset(kLastNNamespace));
+ EXPECT_FALSE(controller()->IsSupportedByDownload(kLastNNamespace));
}
TEST_F(ClientPolicyControllerTest, CheckAsyncDefined) {
OfflinePageClientPolicy policy = controller()->GetPolicy(kAsyncNamespace);
EXPECT_EQ(policy.name_space, kAsyncNamespace);
EXPECT_FALSE(isTemporary(policy));
+ EXPECT_FALSE(controller()->IsRemovedOnCacheReset(kAsyncNamespace));
+ EXPECT_TRUE(controller()->IsSupportedByDownload(kAsyncNamespace));
}
TEST_F(ClientPolicyControllerTest, CheckCCTDefined) {
OfflinePageClientPolicy policy = controller()->GetPolicy(kCCTNamespace);
EXPECT_EQ(policy.name_space, kCCTNamespace);
EXPECT_TRUE(isTemporary(policy));
+ EXPECT_TRUE(controller()->IsRemovedOnCacheReset(kCCTNamespace));
+ EXPECT_FALSE(controller()->IsSupportedByDownload(kCCTNamespace));
}
TEST_F(ClientPolicyControllerTest, CheckDownloadDefined) {
OfflinePageClientPolicy policy = controller()->GetPolicy(kDownloadNamespace);
EXPECT_EQ(policy.name_space, kDownloadNamespace);
EXPECT_FALSE(isTemporary(policy));
+ EXPECT_FALSE(controller()->IsRemovedOnCacheReset(kDownloadNamespace));
+ EXPECT_TRUE(controller()->IsSupportedByDownload(kDownloadNamespace));
}
TEST_F(ClientPolicyControllerTest, CheckNTPSuggestionsDefined) {
@@ -82,6 +94,8 @@ TEST_F(ClientPolicyControllerTest, CheckNTPSuggestionsDefined) {
controller()->GetPolicy(kNTPSuggestionsNamespace);
EXPECT_EQ(policy.name_space, kNTPSuggestionsNamespace);
EXPECT_FALSE(isTemporary(policy));
+ EXPECT_TRUE(controller()->IsRemovedOnCacheReset(kNTPSuggestionsNamespace));
+ EXPECT_FALSE(controller()->IsSupportedByDownload(kNTPSuggestionsNamespace));
}
} // namespace offline_pages
« no previous file with comments | « components/offline_pages/client_policy_controller.cc ('k') | components/offline_pages/offline_page_client_policy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698