Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: ui/views/examples/combobox_example.cc

Issue 2289143004: Add ink drop ripple (but no highlight) to comboboxes in harmony. (Closed)
Patch Set: remove explicit and improve combobox example Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/tree/tree_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/examples/combobox_example.cc
diff --git a/ui/views/examples/combobox_example.cc b/ui/views/examples/combobox_example.cc
index aedc8fbdef73360582f1b4629f224df411721ac3..790d024e37ce750b3cfd17b6b3406ef49c9905a0 100644
--- a/ui/views/examples/combobox_example.cc
+++ b/ui/views/examples/combobox_example.cc
@@ -23,7 +23,7 @@ int ComboboxModelExample::GetItemCount() const {
}
base::string16 ComboboxModelExample::GetItemAt(int index) {
- return base::UTF8ToUTF16(base::StringPrintf("Item %d", index));
+ return base::UTF8ToUTF16(base::StringPrintf("%c item", 'A' + index));
}
ComboboxExample::ComboboxExample() : ExampleBase("Combo Box") {
@@ -56,7 +56,7 @@ void ComboboxExample::CreateExampleView(View* container) {
container->SetLayoutManager(new BoxLayout(
BoxLayout::kVertical,
- 1, 1, 1));
+ 0, 10, 5));
container->AddChildView(combobox_);
container->AddChildView(disabled_combobox_);
container->AddChildView(action_combobox_);
« no previous file with comments | « ui/views/controls/tree/tree_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698