Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: components/password_manager/sync/browser/password_data_type_controller.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase, address comments, remove TestMessageLoop. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/sync/browser/password_data_type_controller.h
diff --git a/components/password_manager/sync/browser/password_data_type_controller.h b/components/password_manager/sync/browser/password_data_type_controller.h
index d4f6d1b6c5242debda488b94feed270e21f9c749..2e196e26a92f2de7899c2ccf3ff4abf1c105a420 100644
--- a/components/password_manager/sync/browser/password_data_type_controller.h
+++ b/components/password_manager/sync/browser/password_data_type_controller.h
@@ -26,20 +26,18 @@ namespace browser_sync {
class PasswordDataTypeController : public sync_driver::NonUIDataTypeController,
public sync_driver::SyncServiceObserver {
public:
+ // |dump_stack| is called when an unrecoverable error occurs.
PasswordDataTypeController(
- const scoped_refptr<base::SingleThreadTaskRunner>& ui_thread,
- const base::Closure& error_callback,
+ const base::Closure& dump_stack,
sync_driver::SyncClient* sync_client,
const base::Closure& state_changed_callback,
const scoped_refptr<password_manager::PasswordStore>& password_store);
+ ~PasswordDataTypeController() override;
// NonFrontendDataTypeController implementation
- syncer::ModelType type() const override;
syncer::ModelSafeGroup model_safe_group() const override;
protected:
- ~PasswordDataTypeController() override;
-
// NonUIDataTypeController interface.
bool PostTaskOnBackendThread(const tracked_objects::Location& from_here,
const base::Closure& task) override;

Powered by Google App Engine
This is Rietveld 408576698