Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: chrome/browser/sync/glue/extension_setting_data_type_controller.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)
Patch Set: Rebase, address comments, remove TestMessageLoop. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/extension_setting_data_type_controller.h
diff --git a/chrome/browser/sync/glue/extension_setting_data_type_controller.h b/chrome/browser/sync/glue/extension_setting_data_type_controller.h
index 9f8e7d8aac36db6befca3e371b7f77bfc892dffb..183c6b5586ebab065e4f759653f202429cbd701d 100644
--- a/chrome/browser/sync/glue/extension_setting_data_type_controller.h
+++ b/chrome/browser/sync/glue/extension_setting_data_type_controller.h
@@ -26,28 +26,24 @@ namespace browser_sync {
class ExtensionSettingDataTypeController
: public sync_driver::NonUIDataTypeController {
public:
+ // |dump_stack| is called when an unrecoverable error occurs.
ExtensionSettingDataTypeController(
// Either EXTENSION_SETTINGS or APP_SETTINGS.
skym 2016/09/02 22:45:28 Can you move this to be able the function itself t
maxbogue 2016/09/03 00:14:50 Done.
syncer::ModelType type,
- const base::Closure& error_callback,
+ const base::Closure& dump_stack,
sync_driver::SyncClient* sync_client,
Profile* profile);
+ ~ExtensionSettingDataTypeController() override;
// NonFrontendDataTypeController implementation
- syncer::ModelType type() const override;
syncer::ModelSafeGroup model_safe_group() const override;
private:
- ~ExtensionSettingDataTypeController() override;
-
// NonFrontendDataTypeController implementation.
bool PostTaskOnBackendThread(const tracked_objects::Location& from_here,
const base::Closure& task) override;
bool StartModels() override;
- // Either EXTENSION_SETTINGS or APP_SETTINGS.
- syncer::ModelType type_;
-
// Only used on the UI thread.
Profile* profile_;

Powered by Google App Engine
This is Rietveld 408576698