components/sync/api/fake_model_type_change_processor.cc - Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/api/fake_model_type_change_processor.cc

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)

Patch Set: Use ThreadChecker instead of NonThreadSafe. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/api/fake_model_type_change_processor.cc

diff --git a/components/sync/api/fake_model_type_change_processor.cc b/components/sync/api/fake_model_type_change_processor.cc

index 65cea5fb64e164ad565ba3afce0683faad8b48f5..d94b03d398505d9bd54a9874880e5cb864f9f4bb 100644

--- a/components/sync/api/fake_model_type_change_processor.cc

+++ b/components/sync/api/fake_model_type_change_processor.cc

@@ -40,7 +40,7 @@ void FakeModelTypeChangeProcessor::OnMetadataLoaded(

std::unique_ptr<MetadataBatch> batch) {}

void FakeModelTypeChangeProcessor::OnSyncStarting(

- syncer::DataTypeErrorHandler* error_handler,

+ std::unique_ptr<syncer::DataTypeErrorHandler> error_handler,

const StartCallback& callback) {

if (!callback.is_null()) {

callback.Run(syncer::SyncError(), nullptr);