components/browser_sync/browser/profile_sync_service_unittest.cc - Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_sync/browser/profile_sync_service_unittest.cc

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)

Patch Set: Use ThreadChecker instead of NonThreadSafe. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/browser_sync/browser/profile_sync_service_unittest.cc

diff --git a/components/browser_sync/browser/profile_sync_service_unittest.cc b/components/browser_sync/browser/profile_sync_service_unittest.cc

index 1e637e452546c820d206f9cfa44e4ffbb67031c5..b438d5c2ed0fa52494bdb073d818b3d4cd8763bf 100644

--- a/components/browser_sync/browser/profile_sync_service_unittest.cc

+++ b/components/browser_sync/browser/profile_sync_service_unittest.cc

@@ -249,7 +249,8 @@ class ProfileSyncServiceTest : public ::testing::Test {

service_.reset(new ProfileSyncService(std::move(init_params)));

service_->RegisterDataTypeController(

- new sync_driver::FakeDataTypeController(syncer::BOOKMARKS));

+ base::MakeUnique<sync_driver::FakeDataTypeController>(

+ syncer::BOOKMARKS));

}

#if defined(OS_WIN) || defined(OS_MACOSX) || \