components/browser_sync/browser/profile_sync_service_startup_unittest.cc - Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_sync/browser/profile_sync_service_startup_unittest.cc

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)

Patch Set: Use ThreadChecker instead of NonThreadSafe. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_wallet_data_type_controller.cc ('K') | « components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc ('k') | components/browser_sync/browser/profile_sync_service_typed_url_unittest.cc » ('j') | components/history/core/browser/history_delete_directives_data_type_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browser_sync/browser/profile_sync_service_startup_unittest.cc

diff --git a/components/browser_sync/browser/profile_sync_service_startup_unittest.cc b/components/browser_sync/browser/profile_sync_service_startup_unittest.cc

index 6d35f16ec8e0e4372a7082628fdac11148c0964d..51f605eb6081b2f2e03ba0aee979e078a36db873 100644

--- a/components/browser_sync/browser/profile_sync_service_startup_unittest.cc

+++ b/components/browser_sync/browser/profile_sync_service_startup_unittest.cc

@@ -97,7 +97,8 @@ class ProfileSyncServiceStartupTest : public testing::Test {

sync_service_.reset(new ProfileSyncService(std::move(init_params)));

sync_service_->RegisterDataTypeController(

- new sync_driver::FakeDataTypeController(syncer::BOOKMARKS));

+ base::MakeUnique<sync_driver::FakeDataTypeController>(

+ syncer::BOOKMARKS));

sync_service_->AddObserver(&observer_);

}