components/browser_sync/browser/profile_sync_service.h - Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_sync/browser/profile_sync_service.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)

Patch Set: Use ThreadChecker instead of NonThreadSafe. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/browser_sync/browser/profile_sync_service.h

diff --git a/components/browser_sync/browser/profile_sync_service.h b/components/browser_sync/browser/profile_sync_service.h

index f6c426846c7385446f3a789785bec1c64988ead9..b264cc131c9b6d001dfcaa40544fbcda5d42586d 100644

--- a/components/browser_sync/browser/profile_sync_service.h

+++ b/components/browser_sync/browser/profile_sync_service.h

@@ -309,7 +309,8 @@ class ProfileSyncService : public sync_driver::SyncService,

bool HasObserver(

const sync_driver::SyncServiceObserver* observer) const override;

void RegisterDataTypeController(

- sync_driver::DataTypeController* data_type_controller) override;

+ std::unique_ptr<sync_driver::DataTypeController> data_type_controller)

+ override;

void ReenableDatatype(syncer::ModelType type) override;

SyncTokenStatus GetSyncTokenStatus() const override;

std::string QuerySyncStatusSummaryString() override;