components/browser_sync/browser/profile_sync_components_factory_impl.h - Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_sync/browser/profile_sync_components_factory_impl.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)

Patch Set: Use ThreadChecker instead of NonThreadSafe. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_wallet_data_type_controller.cc ('K') | « components/autofill/core/browser/webdata/autofill_profile_data_type_controller.cc ('k') | components/browser_sync/browser/profile_sync_components_factory_impl.cc » ('j') | components/history/core/browser/history_delete_directives_data_type_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/browser_sync/browser/profile_sync_components_factory_impl.h

diff --git a/components/browser_sync/browser/profile_sync_components_factory_impl.h b/components/browser_sync/browser/profile_sync_components_factory_impl.h

index 3c04a32dfd7db9433fbfb24916e052bfb4ce869b..6b3024b04ba1605e07fe72235081b6ddfd8dcd6f 100644

--- a/components/browser_sync/browser/profile_sync_components_factory_impl.h

+++ b/components/browser_sync/browser/profile_sync_components_factory_impl.h

@@ -5,6 +5,7 @@

#ifndef COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__

#define COMPONENTS_BROWSER_SYNC_BROWSER_PROFILE_SYNC_COMPONENTS_FACTORY_IMPL_H__

+#include <memory>

#include <string>

#include "base/command_line.h"

@@ -85,7 +86,7 @@ class ProfileSyncComponentsFactoryImpl

sync_driver::SyncApiComponentFactory::SyncComponents

CreateBookmarkSyncComponents(

sync_driver::SyncService* sync_service,

- syncer::DataTypeErrorHandler* error_handler) override;

+ std::unique_ptr<syncer::DataTypeErrorHandler> error_handler) override;

private:

// Register data types which are enabled on both desktop and mobile.