chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h - Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h

Issue 2289143003: [Sync] Convert DTCs to be not RefCounted and NonThreadSafe. (Closed)

Patch Set: Use ThreadChecker instead of NonThreadSafe. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/theme_data_type_controller.cc ('k') | chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc » ('j') | components/autofill/core/browser/autofill_wallet_data_type_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h

diff --git a/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h b/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h

index e665d1abdb14fbe671781981a171a0283621b076..4af6e53f2e4ad73511f751076eb695ade354803a 100644

--- a/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h

+++ b/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h

@@ -22,16 +22,14 @@ class ArcPackageSyncDataTypeController

: public sync_driver::UIDataTypeController {

public:

ArcPackageSyncDataTypeController(syncer::ModelType type,

- const base::Closure& error_callback,

+ const base::Closure& dump_stack,

sync_driver::SyncClient* sync_client,

Profile* profile);

+ ~ArcPackageSyncDataTypeController() override;

bool ReadyForStart() const override;

private:

- // DataTypeController is RefCounted.

- ~ArcPackageSyncDataTypeController() override;

void OnArcAppsSyncPrefChanged();

void OnArcEnabledPrefChanged();