Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2289123005: Don't adjust raster scale differently for SW/GPU during Animation (Closed)

Created:
4 years, 3 months ago by ericrk
Modified:
4 years, 3 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, vmiura
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't adjust raster scale differently for SW/GPU When GPU raster was initially enabled, we caused GPU raster to adjust raster scale during animations, re-rastering each animation frame at its native resolution. While this is theoretically higher quality, this causes GPU raster to do significantly more work than SW in these cases. As downscaling has produced acceptable quality for SW, this change causes GPU to match SW's behavior, improving GPU raster performance in these cases. R=ajuma BUG=624595 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/0230527ec6f04133dcbeb488474c13e895157ea5 Cr-Commit-Position: refs/heads/master@{#415984}

Patch Set 1 #

Patch Set 2 : unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -83 lines) Patch
M cc/layers/picture_layer_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 3 chunks +7 lines, -17 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 3 chunks +3 lines, -65 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
ericrk
4 years, 3 months ago (2016-08-31 23:22:08 UTC) #3
ajuma
lgtm
4 years, 3 months ago (2016-09-01 13:42:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289123005/20001
4 years, 3 months ago (2016-09-01 16:16:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 17:18:23 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 17:19:45 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0230527ec6f04133dcbeb488474c13e895157ea5
Cr-Commit-Position: refs/heads/master@{#415984}

Powered by Google App Engine
This is Rietveld 408576698