chrome/browser/ui/views/toolbar_view.cc - Issue 22891016: Add support for rect-based event targeting in views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 22891016: Add support for rect-based event targeting in views (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comments addressed, moved fuzzing utility functions to new file Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar_view.cc

diff --git a/chrome/browser/ui/views/toolbar_view.cc b/chrome/browser/ui/views/toolbar_view.cc

index 20e815606cfcdbae442134183422bf79cc21883d..7e62c398c8be857d9550d3f15f7732a580662499 100644

--- a/chrome/browser/ui/views/toolbar_view.cc

+++ b/chrome/browser/ui/views/toolbar_view.cc

@@ -567,7 +567,7 @@ void ToolbarView::Layout() {

bool ToolbarView::HitTestRect(const gfx::Rect& rect) const {

// Don't take hits in our top shadow edge. Let them fall through to the

// tab strip above us.

- if (rect.y() < content_shadow_height())

+ if (rect.bottom() < content_shadow_height())

return false;

// Otherwise let our superclass take care of it.

return AccessiblePaneView::HitTestRect(rect);