Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3607)

Unified Diff: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc

Issue 22891016: Add support for rect-based event targeting in views (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch for landing Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
index e9ceab0d590de3104e936104f5bbe5d2fae1e62b..77bd2e93b5d789c628db128f0da77d3e020a0642 100644
--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
@@ -31,6 +31,7 @@
#include "ui/compositor/layer_animator.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/image/image_skia.h"
+#include "ui/gfx/rect_conversions.h"
#include "ui/views/controls/label.h"
#include "ui/views/layout/layout_constants.h"
#include "ui/views/widget/widget.h"
@@ -302,12 +303,11 @@ bool BrowserNonClientFrameViewAsh::HitTestRect(const gfx::Rect& rect) const {
return false;
}
// If the rect is outside the bounds of the client area, claim it.
- // TODO(tdanderson): Implement View::ConvertRectToTarget().
- gfx::Point rect_in_client_view_coords_origin(rect.origin());
- View::ConvertPointToTarget(this, frame()->client_view(),
- &rect_in_client_view_coords_origin);
- gfx::Rect rect_in_client_view_coords(
- rect_in_client_view_coords_origin, rect.size());
+ gfx::RectF rect_in_client_view_coords_f(rect);
+ View::ConvertRectToTarget(this, frame()->client_view(),
+ &rect_in_client_view_coords_f);
+ gfx::Rect rect_in_client_view_coords = gfx::ToEnclosingRect(
+ rect_in_client_view_coords_f);
if (!frame()->client_view()->HitTestRect(rect_in_client_view_coords))
return true;
@@ -317,24 +317,19 @@ bool BrowserNonClientFrameViewAsh::HitTestRect(const gfx::Rect& rect) const {
if (!tabstrip || !browser_view()->IsTabStripVisible())
return false;
- gfx::Point rect_in_tabstrip_coords_origin(rect.origin());
- View::ConvertPointToTarget(this, tabstrip,
- &rect_in_tabstrip_coords_origin);
- gfx::Rect rect_in_tabstrip_coords(rect_in_tabstrip_coords_origin,
- rect.size());
+ gfx::RectF rect_in_tabstrip_coords_f(rect);
+ View::ConvertRectToTarget(this, tabstrip, &rect_in_tabstrip_coords_f);
+ gfx::Rect rect_in_tabstrip_coords = gfx::ToEnclosingRect(
+ rect_in_tabstrip_coords_f);
- if (rect_in_tabstrip_coords.bottom() > tabstrip->GetLocalBounds().bottom()) {
+ if (rect_in_tabstrip_coords.y() > tabstrip->GetLocalBounds().bottom()) {
// |rect| is below the tabstrip.
return false;
}
if (tabstrip->HitTestRect(rect_in_tabstrip_coords)) {
// Claim |rect| if it is in a non-tab portion of the tabstrip.
- // TODO(tdanderson): Pass |rect_in_tabstrip_coords| instead of its center
- // point to TabStrip::IsPositionInWindowCaption() once
- // GetEventHandlerForRect() is implemented.
- return tabstrip->IsPositionInWindowCaption(
- rect_in_tabstrip_coords.CenterPoint());
+ return tabstrip->IsRectInWindowCaption(rect_in_tabstrip_coords);
}
// We claim |rect| because it is above the bottom of the tabstrip, but
« no previous file with comments | « chrome/browser/ui/views/autofill/decorated_textfield.cc ('k') | chrome/browser/ui/views/frame/opaque_browser_frame_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698