Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: src/IceTargetLoweringMIPS32.cpp

Issue 2289043002: [SubZero] Implement lowerSwitch for MIPS (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLoweringMIPS32.cpp
diff --git a/src/IceTargetLoweringMIPS32.cpp b/src/IceTargetLoweringMIPS32.cpp
index 7a3271438b177e00656a560dcd0f2eda173c1e70..e664ffdb50f242a91da8d7af32e020340e7fa876 100644
--- a/src/IceTargetLoweringMIPS32.cpp
+++ b/src/IceTargetLoweringMIPS32.cpp
@@ -2318,7 +2318,38 @@ void TargetMIPS32::lowerStore(const InstStore *Instr) {
void TargetMIPS32::doAddressOptStore() { UnimplementedError(getFlags()); }
void TargetMIPS32::lowerSwitch(const InstSwitch *Instr) {
- UnimplementedLoweringError(this, Instr);
+ Operand *Src = Instr->getComparison();
+ SizeT NumCases = Instr->getNumCases();
+ if (Src->getType() == IceType_i64) {
+ Src = legalizeUndef(Src);
+ Variable *Src0Lo = legalizeToReg(loOperand(Src));
+ Variable *Src0Hi = legalizeToReg(hiOperand(Src));
+ for (SizeT I = 0; I < NumCases; ++I) {
+ Operand *ValueLo = Ctx->getConstantInt32(Instr->getValue(I));
+ Operand *ValueHi = Ctx->getConstantInt32(Instr->getValue(I) >> 32);
+ CfgNode *TargetTrue = Instr->getLabel(I);
+ CfgNode *NoTarget = nullptr;
+ ValueHi = legalize(ValueHi, Legal_Reg);
Jim Stichnoth 2016/08/30 13:20:36 Just use legalizeToReg() here for for ValueLo?
jaydeep.patil 2016/08/31 04:10:23 Done.
+ InstMIPS32Label *IntraLabel = InstMIPS32Label::create(Func, this);
+ _br(NoTarget, NoTarget, Src0Hi, ValueHi, IntraLabel,
+ CondMIPS32::Cond::NE);
+ ValueLo = legalize(ValueLo, Legal_Reg);
+ _br(NoTarget, TargetTrue, Src0Lo, ValueLo, CondMIPS32::Cond::EQ);
+ Context.insert(IntraLabel);
+ }
+ _br(Instr->getLabelDefault());
+ return;
+ }
+ Variable *SrcVar = legalizeToReg(Src);
+ assert(SrcVar->mustHaveReg());
+ for (SizeT I = 0; I < NumCases; ++I) {
+ Operand *Value = Ctx->getConstantInt32(Instr->getValue(I));
+ CfgNode *TargetTrue = Instr->getLabel(I);
+ CfgNode *NoTargetFlase = nullptr;
Jim Stichnoth 2016/08/30 13:20:36 s/Flase/False/ also, use "static constexpr" or "c
jaydeep.patil 2016/08/31 04:10:23 Done.
+ Value = legalize(Value, Legal_Reg);
+ _br(NoTargetFlase, TargetTrue, SrcVar, Value, CondMIPS32::Cond::EQ);
+ }
+ _br(Instr->getLabelDefault());
}
void TargetMIPS32::lowerBreakpoint(const InstBreakpoint *Instr) {

Powered by Google App Engine
This is Rietveld 408576698