Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2289033002: Require extractable=false for KDF import (Closed)

Created:
4 years, 3 months ago by eroman
Modified:
4 years, 3 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Require extractable=false for KDF import This was added to the spec in: https://github.com/w3c/webcrypto/commit/90d9f747da7ab2dd0f88638666c2326dcb953536 BUG=630025 Committed: https://crrev.com/c9529a8212e9ab0eff2679cbc20d8d5d1297b54f Cr-Commit-Position: refs/heads/master@{#417016}

Patch Set 1 #

Patch Set 2 : Add layout tests #

Patch Set 3 : update another test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -31 lines) Patch
M components/webcrypto/algorithms/hkdf.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M components/webcrypto/algorithms/pbkdf2.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M components/webcrypto/status.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/webcrypto/status.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/derive-hkdf-keys.html View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/derive-hkdf-keys-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits-failures.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits-rfc5869-test-vectors.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveBits-rfc5869-test-vectors-expected.txt View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveKey.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/deriveKey-expected.txt View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/exportKey.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/exportKey-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/importKey-failures.html View 1 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/importKey-failures-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/hkdf/unwrapKey.html View 1 1 chunk +0 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/importKey-failures.html View 1 1 chunk +12 lines, -7 lines 0 comments Download
A + third_party/WebKit/LayoutTests/crypto/subtle/pbkdf2/importKey-failures-expected.txt View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 22 (15 generated)
eroman
4 years, 3 months ago (2016-09-06 23:37:50 UTC) #8
Ryan Sleevi
lgtm
4 years, 3 months ago (2016-09-07 18:37:40 UTC) #15
eroman
I failed to mention this in the CL description: This change may cause some compatibility ...
4 years, 3 months ago (2016-09-07 18:48:44 UTC) #16
Ryan Sleevi
On 2016/09/07 18:48:44, eroman wrote: > I failed to mention this in the CL description: ...
4 years, 3 months ago (2016-09-07 18:51:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2289033002/40001
4 years, 3 months ago (2016-09-07 18:54:41 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-07 18:59:53 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 19:02:19 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c9529a8212e9ab0eff2679cbc20d8d5d1297b54f
Cr-Commit-Position: refs/heads/master@{#417016}

Powered by Google App Engine
This is Rietveld 408576698