Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: runtime/bin/process.cc

Issue 22890003: Remove bogus Dart_ExitScope calls (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/process.cc
diff --git a/runtime/bin/process.cc b/runtime/bin/process.cc
index 21750f1ea9c245eea981eb0f14359690101c1892..2fd078f4be9139502ea6d24454f762d43fd61f25 100644
--- a/runtime/bin/process.cc
+++ b/runtime/bin/process.cc
@@ -74,7 +74,6 @@ void FUNCTION_NAME(Process_Start)(Dart_NativeArguments args) {
DartUtils::SetStringField(
status_handle, "_errorMessage", "Path must be a builtin string");
Dart_SetReturnValue(args, Dart_NewBoolean(false));
- Dart_ExitScope();
return;
}
const char* path = DartUtils::GetStringValue(path_handle);
@@ -87,7 +86,6 @@ void FUNCTION_NAME(Process_Start)(Dart_NativeArguments args) {
&args_length);
if (string_args == NULL) {
Dart_SetReturnValue(args, Dart_NewBoolean(false));
- Dart_ExitScope();
return;
}
Dart_Handle working_directory_handle = Dart_GetNativeArgument(args, 3);
@@ -102,7 +100,6 @@ void FUNCTION_NAME(Process_Start)(Dart_NativeArguments args) {
status_handle, "_errorMessage",
"WorkingDirectory must be a builtin string");
Dart_SetReturnValue(args, Dart_NewBoolean(false));
- Dart_ExitScope();
return;
}
Dart_Handle environment = Dart_GetNativeArgument(args, 4);
@@ -117,7 +114,6 @@ void FUNCTION_NAME(Process_Start)(Dart_NativeArguments args) {
if (string_environment == NULL) {
delete[] string_args;
Dart_SetReturnValue(args, Dart_NewBoolean(false));
- Dart_ExitScope();
return;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698