ash: Move AppList support to ShelfWidget, expose ShelfWidget in WmShelf

ash: Move AppList support to ShelfWidget, expose ShelfWidget in WmShelf

This is another step toward eliminating ash::Shelf.

There are enough users of ShelfWidget from WmShelf that I decided to expose
ShelfWidget directly and remove GetShelfWidgetForTesting.

BUG=615502
TEST=ash_unittests

Committed: https://crrev.com/577c95b3c9f75dbd71d60888d0f32f8a26d4e242
Cr-Commit-Position: refs/heads/master@{#415070}

[James Cook, 2016-08-29 22:38:40]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-08-29 22:39:17]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-08-29 22:39:18]

msw, please take a look.

I decided to do this cleanup in a separate CL so the next one will just be
shuffling ownership / creation around.

https://codereview.chromium.org/2288993002/diff/1/ash/common/shelf/wm_shelf.cc
File ash/common/shelf/wm_shelf.cc (right):

https://codereview.chromium.org/2288993002/diff/1/ash/common/shelf/wm_shelf.c...
ash/common/shelf/wm_shelf.cc:51: shelf_widget_ = manager->shelf_widget();
I created a new member here because I wanted outside callers to use
shelf_widget() instead of GetShelfWidget(), since ShelfWidget will be created
and owned here shortly.

[msw, 2016-08-29 22:58:08]

lgtm with nits

https://codereview.chromium.org/2288993002/diff/1/ash/common/shelf/shelf_widg...
File ash/common/shelf/shelf_widget.h (right):

https://codereview.chromium.org/2288993002/diff/1/ash/common/shelf/shelf_widg...
ash/common/shelf/shelf_widget.h:107: // Returns ApplicationDragAndDropHost for
this shelf.
nit: 'Returns the'

https://codereview.chromium.org/2288993002/diff/1/ash/common/shelf/wm_shelf.cc
File ash/common/shelf/wm_shelf.cc (right):

https://codereview.chromium.org/2288993002/diff/1/ash/common/shelf/wm_shelf.c...
ash/common/shelf/wm_shelf.cc:51: shelf_widget_ = manager->shelf_widget();
On 2016/08/29 22:39:17, James Cook wrote:
> I created a new member here because I wanted outside callers to use
> shelf_widget() instead of GetShelfWidget(), since ShelfWidget will be created
> and owned here shortly.

Acknowledged.

https://codereview.chromium.org/2288993002/diff/1/ash/first_run/first_run_hel...
File ash/first_run/first_run_helper_impl.cc (right):

https://codereview.chromium.org/2288993002/diff/1/ash/first_run/first_run_hel...
ash/first_run/first_run_helper_impl.cc:59:
WmShelf::ForWindow(WmLookup::Get()->GetWindowForWidget(widget_));
nit/q: Why look up widget_ instead of using WmShell::GetPrimaryRootWindow()?

[James Cook, 2016-08-29 23:49:25]

Thanks for the quick review.

https://codereview.chromium.org/2288993002/diff/1/ash/common/shelf/shelf_widg...
File ash/common/shelf/shelf_widget.h (right):

https://codereview.chromium.org/2288993002/diff/1/ash/common/shelf/shelf_widg...
ash/common/shelf/shelf_widget.h:107: // Returns ApplicationDragAndDropHost for
this shelf.
On 2016/08/29 22:58:08, msw wrote:
> nit: 'Returns the'

Done.

https://codereview.chromium.org/2288993002/diff/1/ash/first_run/first_run_hel...
File ash/first_run/first_run_helper_impl.cc (right):

https://codereview.chromium.org/2288993002/diff/1/ash/first_run/first_run_hel...
ash/first_run/first_run_helper_impl.cc:59:
WmShelf::ForWindow(WmLookup::Get()->GetWindowForWidget(widget_));
On 2016/08/29 22:58:08, msw wrote:
> nit/q: Why look up widget_ instead of using WmShell::GetPrimaryRootWindow()?

No particularly good reason. Switched to WmShell::GetPrimaryRootWindow().

[James Cook, 2016-08-30 00:02:56]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-08-30 00:02:57]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2288993002/#ps40001
(title: "rebase")

[James Cook, 2016-08-30 01:37:50]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-08-30 01:37:50]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2288993002/#ps60001
(title: "missed one unit test")

[commit-bot: I haz the power, 2016-08-30 02:09:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:42:15]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2016-08-30 04:04:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-30 04:06:56]

Description was changed from

==========
ash: Move AppList support to ShelfWidget, expose ShelfWidget in WmShelf

This is another step toward eliminating ash::Shelf.

There are enough users of ShelfWidget from WmShelf that I decided to expose
ShelfWidget directly and remove GetShelfWidgetForTesting.

BUG=615502
TEST=ash_unittests
==========

to

==========
ash: Move AppList support to ShelfWidget, expose ShelfWidget in WmShelf

This is another step toward eliminating ash::Shelf.

There are enough users of ShelfWidget from WmShelf that I decided to expose
ShelfWidget directly and remove GetShelfWidgetForTesting.

BUG=615502
TEST=ash_unittests

Committed: https://crrev.com/577c95b3c9f75dbd71d60888d0f32f8a26d4e242
Cr-Commit-Position: refs/heads/master@{#415070}
==========

[commit-bot: I haz the power, 2016-08-30 04:06:57]

Patchset 4 (id:??) landed as
https://crrev.com/577c95b3c9f75dbd71d60888d0f32f8a26d4e242
Cr-Commit-Position: refs/heads/master@{#415070}