Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2288983004: Merge TaskSynchronizer into WaitableEvent. (Closed)

Created:
4 years, 3 months ago by keishi
Modified:
4 years, 3 months ago
Reviewers:
haraken
CC:
chromium-reviews, tyoshino+watch_chromium.org, dtapuska+blinkwatch_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, eae+blinkwatch, loading-reviews+parser_chromium.org, hongchan, haraken, loading-reviews_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, blink-reviews, kinuko+watch, Nate Chapin, Raymond Toy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge TaskSynchronizer into WaitableEvent. BUG= patch from issue 2288973002 at patchset 1 (http://crrev.com/2288973002#ps1) Committed: https://crrev.com/e3e66329cbaa1bc4be0bf95a02578f488549b2b2 Cr-Commit-Position: refs/heads/master@{#415834}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -189 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserThread.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/Database.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h View 5 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseTask.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseThread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 1 1 chunk +1 line, -4 lines 0 comments Download
D third_party/WebKit/Source/platform/TaskSynchronizer.h View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/WebKit/Source/platform/TaskSynchronizer.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
M third_party/WebKit/Source/platform/WaitableEvent.cpp View 2 chunks +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.h View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
haraken
LGTM
4 years, 3 months ago (2016-08-30 15:36:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288983004/20001
4 years, 3 months ago (2016-09-01 01:18:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 01:23:32 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 01:37:42 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e3e66329cbaa1bc4be0bf95a02578f488549b2b2
Cr-Commit-Position: refs/heads/master@{#415834}

Powered by Google App Engine
This is Rietveld 408576698