Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

Issue 2288983003: DevTools: Show events from all processes on timeline. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
index 491ecee9ad09c5d37e17e2585c13db4d9fc4fafb..853d198f00906cc7154fbf633754d6f7f3a1c1f1 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js
@@ -495,24 +495,32 @@ WebInspector.TimelineModel.prototype = {
this._maximumRecordTime = tracingModel.maximumRecordTime();
var metadataEvents = this._processMetadataEvents(tracingModel, !!produceTraceStartedInPage);
- var startTime = 0;
- for (var i = 0, length = metadataEvents.page.length; i < length; i++) {
- var metaEvent = metadataEvents.page[i];
- var process = metaEvent.thread.process();
- var endTime = i + 1 < length ? metadataEvents.page[i + 1].startTime : Infinity;
- this._currentPage = metaEvent.args["data"] && metaEvent.args["data"]["page"];
- for (var thread of process.sortedThreads()) {
- if (thread.name() === WebInspector.TimelineModel.WorkerThreadName) {
- var workerMetaEvent = metadataEvents.workers.find(e => e.args["data"]["workerThreadId"] === thread.id());
- if (!workerMetaEvent)
- continue;
- var workerId = workerMetaEvent.args["data"]["workerId"];
- if (workerId)
- this._workerIdByThread.set(thread, workerId);
+ if (Runtime.experiments.isEnabled("timelineShowAllProcesses")) {
+ var lastPageMetaEvent = metadataEvents.page.peekLast();
+ for (var process of tracingModel.sortedProcesses()) {
+ for (var thread of process.sortedThreads())
+ this._processThreadEvents(0, Infinity, thread, thread === lastPageMetaEvent.thread);
+ }
+ } else {
+ var startTime = 0;
+ for (var i = 0, length = metadataEvents.page.length; i < length; i++) {
+ var metaEvent = metadataEvents.page[i];
+ var process = metaEvent.thread.process();
+ var endTime = i + 1 < length ? metadataEvents.page[i + 1].startTime : Infinity;
+ this._currentPage = metaEvent.args["data"] && metaEvent.args["data"]["page"];
+ for (var thread of process.sortedThreads()) {
+ if (thread.name() === WebInspector.TimelineModel.WorkerThreadName) {
+ var workerMetaEvent = metadataEvents.workers.find(e => e.args["data"]["workerThreadId"] === thread.id());
+ if (!workerMetaEvent)
+ continue;
+ var workerId = workerMetaEvent.args["data"]["workerId"];
+ if (workerId)
+ this._workerIdByThread.set(thread, workerId);
+ }
+ this._processThreadEvents(startTime, endTime, thread, thread === metaEvent.thread);
}
- this._processThreadEvents(startTime, endTime, thread, thread === metaEvent.thread);
+ startTime = endTime;
}
- startTime = endTime;
}
this._inspectedTargetEvents.sort(WebInspector.TracingModel.Event.compareStartTime);
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698