Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7648)

Unified Diff: chromecast/BUILD.gn

Issue 2288953002: [Chromecast] Only include all libstdc++/libgcc symbols in executable as needed (Closed)
Patch Set: Refactored conditional Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/chromecast/BUILD.gn ('k') | chromecast/crash/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/BUILD.gn
diff --git a/chromecast/BUILD.gn b/chromecast/BUILD.gn
index 8e1c18e9b1ada95972901d72f36b892024d8a274..a08c11a0ca4c06cd3b65a329152dd32b9e779103 100644
--- a/chromecast/BUILD.gn
+++ b/chromecast/BUILD.gn
@@ -223,6 +223,10 @@ executable("cast_shell") {
if (chromecast_branding != "public") {
deps += [ "//chromecast/internal:cast_shell_internal" ]
}
+
+ # Whole archiving libgcc.a and libstdc++ is needed if dynamic share libs are
+ # used, see b/25566835.
+ configs += [ "//build/config/chromecast:executable_whole_archive_config" ]
}
repack("cast_shell_pak") {
« no previous file with comments | « build/config/chromecast/BUILD.gn ('k') | chromecast/crash/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698