Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chromecast/crash/BUILD.gn

Issue 2288953002: [Chromecast] Only include all libstdc++/libgcc symbols in executable as needed (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/chromecast/BUILD.gn ('K') | « chromecast/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/crash/BUILD.gn
diff --git a/chromecast/crash/BUILD.gn b/chromecast/crash/BUILD.gn
index bb261ce8f0bca2eb3ddef9cb32b6d4a2271a71a5..a2b2c97580f64f8181380e48f4d3c1403655cdb7 100644
--- a/chromecast/crash/BUILD.gn
+++ b/chromecast/crash/BUILD.gn
@@ -43,6 +43,10 @@ source_set("crash") {
deps += [ "//chromecast/base:cast_sys_info" ]
} else {
deps += [ "//chromecast/base:cast_sys_info_shlib" ]
+
+ # whole archiving libgcc.a and libstdc++ is needed if dynamic share libs
+ # are used, see b/25566835
+ configs += [ "//build/config/chromecast:executable_whole_archive_config" ]
bcf 2016/08/29 21:22:51 How about put this under executable("crash_upload
antz1 2016/08/29 23:09:33 Done.
}
}
« build/config/chromecast/BUILD.gn ('K') | « chromecast/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698