[Chromecast] Only include all libstdc++/libgcc symbols in executable as needed

build/config/chromecast/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chromecast_build.gni")
 
 assert(is_chromecast)
 
 config("static_config") {
   ldflags = [
@@ skipping 16 matching lines @@
   # This is explicitly disabled in Chrome for security reasons (see comments in
   # //build/config/gcc/BUILD.gn), but necessary on Chromecast so that OEM's may
   # override the default libraries shipped in the Cast receiver package.
   ldflags = [
     "-Wl,-rpath=/oem_cast_shlib",
     "-Wl,-rpath=\$ORIGIN/lib",
     "-Wl,-rpath=\$ORIGIN",
   ]
 }
 
-config("executable_config") {
-  configs = [ ":ldconfig" ]
-
-  if (current_cpu == "arm") {
+# Whole archiving libgcc.a and libstdc++ is needed if dynamic share libs are

[scottmg, 2016/09/02 20:40:55]

"share" -> "shared"

[antz1, 2016/09/02 21:22:53]

Done.

+# used, see b/25566835.
+config("executable_whole_archive_config") {
+  if (current_cpu == "arm" && !is_android) {

[scottmg, 2016/09/02 20:40:55]

Isn't there an is_chromecast, if that's what's meant here?

[antz1, 2016/09/02 21:22:53]

is_chromecast is set for our android builds, which we do not want to statically
link these libs. We want to do them for arm device builds.

     ldflags = [
       # Export stdlibc++ and libgcc symbols to force shlibs to refer to these
       # symbols from the executable.
       "-Wl,--export-dynamic",
 
       "-lm",  # stdlibc++ requires math.h
 
-      # In case we redefined stdlibc++ symbols (e.g. tc_malloc)
+      # In case we redefined stdlibc++ symbols (e.g. tc_malloc).
       "-Wl,--allow-multiple-definition",
 
+      # Adding all symbols from libgcc and libstdc++.
       "-Wl,--whole-archive",
       "-l:libstdc++.a",
       "-l:libgcc.a",
       "-Wl,--no-whole-archive",
     ]
+  }
+}
 
-    # Despite including libstdc++/libgcc archives, we still need to specify
-    # static linking for them in order to prevent the executable from having a
-    # dynamic dependency on them.
+# Statically linking against libstdc++/libgcc should happen for arm chromecast
+# devices, and is not needed for Android builds.
+config("executable_config") {
+  configs = [ ":ldconfig" ]
+
+  if (current_cpu == "arm" && !is_android) {

[bcf, 2016/09/02 20:35:12]

Define variable for this at top.

[scottmg, 2016/09/02 20:40:55]

And here?

+    # Statically link libstdc++ and libgcc to avoid having a dynamic dependency
+    # on them.
     configs += [ ":static_config" ]
   }
 }
 
 config("shared_library_config") {
   configs = [ ":ldconfig" ]
-  if (current_cpu == "arm") {
+  if (current_cpu == "arm" && !is_android) {
     configs += [ ":static_config" ]
   }
 }