Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2288943003: Move websocket owners to the right directory (Closed)

Created:
4 years, 3 months ago by yhirano
Modified:
4 years, 3 months ago
Reviewers:
Adam Rice, jam
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move websocket owners to the right directory WebSocket implementation in content/browser was moved from content/browser/renderer_host to content/browser/websockets. This change updates the OWNERS information. BUG=None Committed: https://crrev.com/3a2f1b0c02f7acfc223c3f4a908f9f2e0fefc3a0 Cr-Commit-Position: refs/heads/master@{#415522}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -4 lines) Patch
M content/browser/renderer_host/OWNERS View 1 chunk +0 lines, -5 lines 0 comments Download
A + content/browser/websockets/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
yhirano
https://crrev.com/fa18d502ca7285b4f9c5efad788e959c860ed9c6
4 years, 3 months ago (2016-08-30 06:28:31 UTC) #8
Adam Rice
lgtm
4 years, 3 months ago (2016-08-30 06:44:32 UTC) #10
jam
lgtm
4 years, 3 months ago (2016-08-30 16:39:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288943003/20001
4 years, 3 months ago (2016-08-31 00:43:44 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 00:47:56 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 00:49:39 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3a2f1b0c02f7acfc223c3f4a908f9f2e0fefc3a0
Cr-Commit-Position: refs/heads/master@{#415522}

Powered by Google App Engine
This is Rietveld 408576698