Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2288923002: Fix stroked rrects with batching. (Closed)

Created:
4 years, 3 months ago by jvanverth1
Modified:
4 years, 3 months ago
Reviewers:
bsalomon, djsollen
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix stroked rrects with batching. Was using stroked shader for fills and vice versa. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288923002 TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/a3992bfb837bbc5070688fe7d8e83290ef5ae26a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/GrOvalRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
jvanverth1
4 years, 3 months ago (2016-08-29 20:13:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288923002/1
4 years, 3 months ago (2016-08-29 20:14:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/a3992bfb837bbc5070688fe7d8e83290ef5ae26a
4 years, 3 months ago (2016-08-29 20:50:10 UTC) #8
bsalomon
4 years, 3 months ago (2016-08-29 21:00:31 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698