third_party/WebKit/Source/core/editing/EditingUtilities.cpp - Issue 2288913002: [InputEvent] Support |deleteByDrag| and |insertFromDrop|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Issue 2288913002: [InputEvent] Support |deleteByDrag| and |insertFromDrop| (Closed)

Patch Set: yosin's review 3, check |ownerDocument()| Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/resources/beforeinput-remove-iframe-crash-iframe.html ('k') | third_party/WebKit/Source/core/editing/Editor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

index 5f960c5f295284722b9edb50da0fc28cc504e60a..09dde6c63a3cbcfb1a56aaf072b65f36a479aa44 100644

--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

@@ -1864,8 +1864,6 @@ DispatchEventResult dispatchBeforeInputInsertText(EventTarget* target, const Str

return DispatchEventResult::NotCanceled;

if (!target)

return DispatchEventResult::NotCanceled;

- // TODO(chongz): Pass appreciate |ranges| after it's defined on spec.

- // http://w3c.github.io/editing/input-events.html#dom-inputevent-inputtype

InputEvent* beforeInputEvent = InputEvent::createBeforeInput(InputEvent::InputType::InsertText, data, InputEvent::EventCancelable::IsCancelable, InputEvent::EventIsComposing::NotComposing, nullptr);

return target->dispatchEvent(beforeInputEvent);

}

@@ -1876,7 +1874,7 @@ DispatchEventResult dispatchBeforeInputFromComposition(EventTarget* target, Inpu

return DispatchEventResult::NotCanceled;

if (!target)

return DispatchEventResult::NotCanceled;

- // TODO(chongz): Pass appreciate |ranges| after it's defined on spec.

+ // TODO(chongz): Pass appreciate |ranges| after it's defined on spec. e.g. For |DeleteComposedCharacterBackward|.

// http://w3c.github.io/editing/input-events.html#dom-inputevent-inputtype

InputEvent* beforeInputEvent = InputEvent::createBeforeInput(inputType, data, cancelable, InputEvent::EventIsComposing::IsComposing, nullptr);

return target->dispatchEvent(beforeInputEvent);