Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Issue 2288913002: [InputEvent] Support |deleteByDrag| and |insertFromDrop| (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
index 89c8fd5ea9dce1af5bf5a9611648c253199e9969..0682bdfbb4d82d7be707f5c038f1b7bc10810ca7 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
@@ -1863,8 +1863,6 @@ DispatchEventResult dispatchBeforeInputInsertText(EventTarget* target, const Str
return DispatchEventResult::NotCanceled;
if (!target)
return DispatchEventResult::NotCanceled;
- // TODO(chongz): Pass appreciate |ranges| after it's defined on spec.
- // http://w3c.github.io/editing/input-events.html#dom-inputevent-inputtype
InputEvent* beforeInputEvent = InputEvent::createBeforeInput(InputEvent::InputType::InsertText, data, InputEvent::EventCancelable::IsCancelable, InputEvent::EventIsComposing::NotComposing, nullptr);
return target->dispatchEvent(beforeInputEvent);
}
@@ -1875,7 +1873,7 @@ DispatchEventResult dispatchBeforeInputFromComposition(EventTarget* target, Inpu
return DispatchEventResult::NotCanceled;
if (!target)
return DispatchEventResult::NotCanceled;
- // TODO(chongz): Pass appreciate |ranges| after it's defined on spec.
+ // TODO(chongz): Pass appreciate |ranges| after it's defined on spec. e.g. For |DeleteComposedCharacterBackward|.
// http://w3c.github.io/editing/input-events.html#dom-inputevent-inputtype
InputEvent* beforeInputEvent = InputEvent::createBeforeInput(inputType, data, cancelable, InputEvent::EventIsComposing::IsComposing, nullptr);
return target->dispatchEvent(beforeInputEvent);

Powered by Google App Engine
This is Rietveld 408576698