[telemetry] Move camel_case_converter out of chrome/ and use it for discover, as well.

[telemetry] Move camel_case_converter out of chrome/ and use it for discover, as well.

Also refine its interface to make it more concise and add more unit tests.


BUG=None.
TEST=tools/telemetry/run_tests --browser=system

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218355

[tonyg, 2013-08-16 23:46:30]

lgtm

https://codereview.chromium.org/22889009/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/camel_case.py (right):

https://codereview.chromium.org/22889009/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/camel_case.py:8: def ToUnderscore(obj):
Really clean implementation, I like it

https://codereview.chromium.org/22889009/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/camel_case_unittest.py (right):

https://codereview.chromium.org/22889009/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/camel_case_unittest.py:12:
self.assertEqual(camel_case.ToUnderscore('camelCase'), 'camel_case')
Aren't the expectations usually the first arg?

[dtu, 2013-08-17 00:19:34]

https://codereview.chromium.org/22889009/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/camel_case.py (right):

https://codereview.chromium.org/22889009/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/camel_case.py:8: def ToUnderscore(obj):
On 2013/08/16 23:46:30, tonyg wrote:
> Really clean implementation, I like it

Thanks!

https://codereview.chromium.org/22889009/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/camel_case_unittest.py (right):

https://codereview.chromium.org/22889009/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/camel_case_unittest.py:12:
self.assertEqual(camel_case.ToUnderscore('camelCase'), 'camel_case')
On 2013/08/16 23:46:30, tonyg wrote:
> Aren't the expectations usually the first arg?

No, I don't think so. Only for assertRaises.

[commit-bot: I haz the power, 2013-08-17 00:43:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/22889009/1

[commit-bot: I haz the power, 2013-08-17 01:20:25]

Retried try job too often on ios_dbg_simulator for step(s) media_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-08-17 01:37:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/22889009/1

[commit-bot: I haz the power, 2013-08-17 02:01:43]

Retried try job too often on ios_dbg_simulator for step(s) media_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-08-19 17:59:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/22889009/1

[commit-bot: I haz the power, 2013-08-19 22:46:42]

Change committed as 218355