Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1595)

Unified Diff: runtime/vm/exceptions.cc

Issue 22889002: Fix minor bug which was causing throw of Null to not be recognized properly. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/corelib/corelib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/exceptions.cc
===================================================================
--- runtime/vm/exceptions.cc (revision 26010)
+++ runtime/vm/exceptions.cc (working copy)
@@ -364,7 +364,7 @@
&frame_builder);
} else {
const Field& stacktrace_field =
- Field::Handle(LookupStacktraceField(incoming_exception));
+ Field::Handle(LookupStacktraceField(exception));
bool full_stacktrace = !stacktrace_field.IsNull();
RegularStacktraceBuilder frame_builder(full_stacktrace);
handler_exists = FindExceptionHandler(&handler_pc,
@@ -396,8 +396,8 @@
stacktrace.SetCatchStacktrace(catch_func_array,
catch_code_array,
catch_pc_offset_array);
- if (incoming_exception.GetField(stacktrace_field) == Object::null()) {
- incoming_exception.SetField(stacktrace_field, stacktrace);
+ if (exception.GetField(stacktrace_field) == Object::null()) {
+ exception.SetField(stacktrace_field, stacktrace);
}
}
// TODO(5411263): At some point we can optimize by figuring out if a
« no previous file with comments | « no previous file | tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698