Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2288843002: Fix QUIC connection's last_send_for_timeout_ (Closed)

Created:
4 years, 3 months ago by Ryan Hamilton
Modified:
4 years, 3 months ago
Reviewers:
ianswett, Jana
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set QUIC connection's last_send_for_timeout_ to the send time of the first sent packet after receiving a packet, even if the sent packet is not a retransmission. Protected by default enabled --quic_better_last_send_for_timeout Merge internal change: 131623416 BUG=642017 Committed: https://crrev.com/10ae460d345bb14f03972f43c253c822e08ed5e2 Cr-Commit-Position: refs/heads/master@{#415157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -5 lines) Patch
M net/quic/core/quic_connection.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 4 chunks +89 lines, -5 lines 0 comments Download
M net/quic/core/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_flags.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Ryan Hamilton
4 years, 3 months ago (2016-08-29 17:38:43 UTC) #3
Jana
lgtm
4 years, 3 months ago (2016-08-29 17:40:43 UTC) #4
ianswett
lgtm
4 years, 3 months ago (2016-08-29 17:43:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288843002/1
4 years, 3 months ago (2016-08-29 17:52:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 05:29:41 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:31:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10ae460d345bb14f03972f43c253c822e08ed5e2
Cr-Commit-Position: refs/heads/master@{#415157}

Powered by Google App Engine
This is Rietveld 408576698