Issue 228883004: Allow trychange to submit empty patch sets again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 228883004: Allow trychange to submit empty patch sets again. (Closed)

Created:
6 years, 8 months ago by bradn

Modified:
6 years, 8 months ago

Reviewers:
Nico, nodir, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Allow trychange to submit empty patch sets again. A recent change to trychange prevents empty patches from being submitted: https://codereview.chromium.org/184343003/diff/210001/trychange.py parasite (used for the gyp waterfall) relies on empty patches to share nacl trybots to build gyp at particular revisions. BUG=None TEST=local on master3 R=nodir@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=262493

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	trychange.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/228883004/1

6 years, 8 months ago (2014-04-08 20:01:54 UTC) #5

Message was sent while issue was closed.

Change committed as 262493