Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 228883003: Remove known root detection logic on Android. (Closed)

Created:
6 years, 8 months ago by davidben
Modified:
6 years, 8 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Remove known root detection logic on Android. The implementation has a high startup overhead. Remove it for now and default the value to false; this disables the intranet name detector since we cannot distinguish private CAs from public ones. BUG=361166 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -80 lines) Patch
M net/android/java/src/org/chromium/net/X509Util.java View 8 chunks +3 lines, -76 lines 0 comments Download
M net/cert/cert_verify_proc_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davidben
6 years, 8 months ago (2014-04-08 17:34:47 UTC) #1
Ryan Sleevi
lgtm
6 years, 8 months ago (2014-04-08 20:15:54 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 8 months ago (2014-04-08 21:13:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/228883003/1
6 years, 8 months ago (2014-04-08 21:14:35 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 22:18:57 UTC) #5
Message was sent while issue was closed.
Change committed as 262521

Powered by Google App Engine
This is Rietveld 408576698