device/bluetooth: Fix Interger type for DBus message construction

device/bluetooth: Fix Interger type for DBus message construction

When dbus::AppendValueDataAsVariant encounter with an integer type.
It always assume that it is a signed integer 32-bit. This would make
SDP record creation fail in BlueZ as correct type and signed for
integer type is expected.

This CL properly read integer data from base::Value and send it to
BlueZ with the correct type.

BUG=b:29314637
TEST=Bluez does not crash when call CreateServiceRecord

Committed: https://crrev.com/2d7cfc0777b0b222c938550439832c100516ada3
Cr-Commit-Position: refs/heads/master@{#415239}

[puthik_chromium, 2016-08-29 21:25:19]

puthik@chromium.org changed reviewers:
+ steel@chromium.org

[puthik_chromium, 2016-08-29 21:25:20]

steel, Please review
fyi: mcchou, snanda

[puthik_chromium, 2016-08-29 21:26:08]

The CQ bit was checked by puthik@chromium.org to run a CQ dry run

[puthik_chromium, 2016-08-29 21:28:42]

Description was changed from

==========
device/bluetooth: Fix DBus message construction of CreateServiceRecord method

When dbus::AppendValueDataAsVariant encounter with an integer type.
It always assume that it is a signed integer 32-bit. This would make
SDP record creation fail in BlueZ as correct type and signed for
integer type is expected.

This CL properly read integer data from base::Value and send it to
BlueZ with the correct type.

BUG=b:29314637
TEST=Bluez does not crash when call CreateServiceRecord
==========

to

==========
device/bluetooth: Fix Interger type for DBus message construction

When dbus::AppendValueDataAsVariant encounter with an integer type.
It always assume that it is a signed integer 32-bit. This would make
SDP record creation fail in BlueZ as correct type and signed for
integer type is expected.

This CL properly read integer data from base::Value and send it to
BlueZ with the correct type.

BUG=b:29314637
TEST=Bluez does not crash when call CreateServiceRecord
==========

[puthik_chromium, 2016-08-29 21:29:25]

The CQ bit was checked by puthik@chromium.org to run a CQ dry run

[Miao, 2016-08-29 21:30:33]

mcchou@chromium.org changed reviewers:
+ mcchou@chromium.org

[Miao, 2016-08-29 21:30:34]

lgtm

[commit-bot: I haz the power, 2016-08-29 21:59:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Rahul Chaturvedi, 2016-08-29 22:00:29]

https://codereview.chromium.org/2288823003/diff/1/device/bluetooth/dbus/bluet...
File device/bluetooth/dbus/bluetooth_adapter_client.cc (right):

https://codereview.chromium.org/2288823003/diff/1/device/bluetooth/dbus/bluet...
device/bluetooth/dbus/bluetooth_adapter_client.cc:38:
writer->OpenVariant(std::string(1, dbus::Message::DataType::BYTE),
Instead of doing OpenVariant, then Append and CloseContainer, maybe just use
AppendVariantOfUint32, etc?

[puthik_chromium, 2016-08-29 22:17:10]

https://codereview.chromium.org/2288823003/diff/1/device/bluetooth/dbus/bluet...
File device/bluetooth/dbus/bluetooth_adapter_client.cc (right):

https://codereview.chromium.org/2288823003/diff/1/device/bluetooth/dbus/bluet...
device/bluetooth/dbus/bluetooth_adapter_client.cc:38:
writer->OpenVariant(std::string(1, dbus::Message::DataType::BYTE),
On 2016/08/29 22:00:29, Rahul Chaturvedi wrote:
> Instead of doing OpenVariant, then Append and CloseContainer, maybe just use
> AppendVariantOfUint32, etc?

Done. Forgot that we have those API.

[puthik_chromium, 2016-08-29 22:17:21]

The CQ bit was checked by puthik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 23:01:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:41:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:41:55]

Dry run: This issue passed the CQ dry run.

[Rahul Chaturvedi, 2016-08-30 05:35:37]

lgtm

https://codereview.chromium.org/2288823003/diff/20001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluetooth_adapter_client.cc (right):

https://codereview.chromium.org/2288823003/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_adapter_client.cc:28: void
WriteNumberAttribute(dbus::MessageWriter* writer,
Nit: Add a TODO(rkc) here to find a better way to do this.

[puthik_chromium, 2016-08-30 06:00:21]

The CQ bit was checked by puthik@chromium.org

[puthik_chromium, 2016-08-30 06:00:21]

The patchset sent to the CQ was uploaded after l-g-t-m from mcchou@chromium.org
Link to the patchset: https://codereview.chromium.org/2288823003/#ps20001
(title: "Use append varientOf...")

[puthik_chromium, 2016-08-30 06:00:31]

The CQ bit was unchecked by puthik@chromium.org

[puthik_chromium, 2016-08-30 06:05:32]

https://codereview.chromium.org/2288823003/diff/20001/device/bluetooth/dbus/b...
File device/bluetooth/dbus/bluetooth_adapter_client.cc (right):

https://codereview.chromium.org/2288823003/diff/20001/device/bluetooth/dbus/b...
device/bluetooth/dbus/bluetooth_adapter_client.cc:28: void
WriteNumberAttribute(dbus::MessageWriter* writer,
On 2016/08/30 05:35:37, Rahul Chaturvedi wrote:
> Nit: Add a TODO(rkc) here to find a better way to do this.

Done.

[puthik_chromium, 2016-08-30 06:05:35]

The CQ bit was checked by puthik@chromium.org

[puthik_chromium, 2016-08-30 06:05:36]

The patchset sent to the CQ was uploaded after l-g-t-m from mcchou@chromium.org,
steel@chromium.org
Link to the patchset: https://codereview.chromium.org/2288823003/#ps40001
(title: "Add todo")

[commit-bot: I haz the power, 2016-08-30 06:06:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 08:07:07]

Description was changed from

==========
device/bluetooth: Fix Interger type for DBus message construction

When dbus::AppendValueDataAsVariant encounter with an integer type.
It always assume that it is a signed integer 32-bit. This would make
SDP record creation fail in BlueZ as correct type and signed for
integer type is expected.

This CL properly read integer data from base::Value and send it to
BlueZ with the correct type.

BUG=b:29314637
TEST=Bluez does not crash when call CreateServiceRecord
==========

to

==========
device/bluetooth: Fix Interger type for DBus message construction

When dbus::AppendValueDataAsVariant encounter with an integer type.
It always assume that it is a signed integer 32-bit. This would make
SDP record creation fail in BlueZ as correct type and signed for
integer type is expected.

This CL properly read integer data from base::Value and send it to
BlueZ with the correct type.

BUG=b:29314637
TEST=Bluez does not crash when call CreateServiceRecord
==========

[commit-bot: I haz the power, 2016-08-30 08:07:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-30 08:08:43]

Description was changed from

==========
device/bluetooth: Fix Interger type for DBus message construction

When dbus::AppendValueDataAsVariant encounter with an integer type.
It always assume that it is a signed integer 32-bit. This would make
SDP record creation fail in BlueZ as correct type and signed for
integer type is expected.

This CL properly read integer data from base::Value and send it to
BlueZ with the correct type.

BUG=b:29314637
TEST=Bluez does not crash when call CreateServiceRecord
==========

to

==========
device/bluetooth: Fix Interger type for DBus message construction

When dbus::AppendValueDataAsVariant encounter with an integer type.
It always assume that it is a signed integer 32-bit. This would make
SDP record creation fail in BlueZ as correct type and signed for
integer type is expected.

This CL properly read integer data from base::Value and send it to
BlueZ with the correct type.

BUG=b:29314637
TEST=Bluez does not crash when call CreateServiceRecord

Committed: https://crrev.com/2d7cfc0777b0b222c938550439832c100516ada3
Cr-Commit-Position: refs/heads/master@{#415239}
==========

[commit-bot: I haz the power, 2016-08-30 08:08:44]

Patchset 3 (id:??) landed as
https://crrev.com/2d7cfc0777b0b222c938550439832c100516ada3
Cr-Commit-Position: refs/heads/master@{#415239}