Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2288823002: [Offline Pages] Removes check on deprecated IsOfflinePagesEnabled flag from BrowsingDataRemover (Closed)

Created:
4 years, 3 months ago by dougarnett
Modified:
4 years, 3 months ago
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Removes check on deprecated IsOfflinePagesEnabled flag from BrowsingDataRemover BUG=639354 Committed: https://crrev.com/1bf1e183f5e7ffd28b687b0e2107479f92dee00d Cr-Commit-Position: refs/heads/master@{#415075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/browsing_data/browsing_data_remover.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
dougarnett
4 years, 3 months ago (2016-08-29 16:58:43 UTC) #3
fgorski
lgtm
4 years, 3 months ago (2016-08-29 17:03:40 UTC) #4
dougarnett
4 years, 3 months ago (2016-08-29 18:13:54 UTC) #7
msramek
LGTM
4 years, 3 months ago (2016-08-29 21:03:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288823002/1
4 years, 3 months ago (2016-08-30 02:09:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 04:09:05 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:11:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bf1e183f5e7ffd28b687b0e2107479f92dee00d
Cr-Commit-Position: refs/heads/master@{#415075}

Powered by Google App Engine
This is Rietveld 408576698