Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1527)

Issue 2288813003: [test] Speed-up regression test for growing stores. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Speed-up regression test for growing stores. TBR=machenbach@chromium.org BUG=chromium:635798, chromium:638295 Committed: https://crrev.com/864cdc124c55f48740100a4dcaa3b5582040d815 Cr-Commit-Position: refs/heads/master@{#38991}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/mjsunit/regress/regress-crbug-635798.js View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-30 03:41:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288813003/1
4 years, 3 months ago (2016-08-30 03:42:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288813003/1
4 years, 3 months ago (2016-08-30 03:43:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 04:04:10 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/864cdc124c55f48740100a4dcaa3b5582040d815 Cr-Commit-Position: refs/heads/master@{#38991}
4 years, 3 months ago (2016-08-30 04:04:44 UTC) #11
Michael Achenbach
4 years, 3 months ago (2016-08-30 06:55:18 UTC) #12
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2288813003/diff/1/test/mjsunit/regress/regres...
File test/mjsunit/regress/regress-crbug-635798.js (right):

https://codereview.chromium.org/2288813003/diff/1/test/mjsunit/regress/regres...
test/mjsunit/regress/regress-crbug-635798.js:11: for (var i = 0; i < 10000; ++i)
{
Would that still reproduce the original bug? I.e. is it a valuable regression
test? Did you check what's the lower bound or is this number just as random as
the first?

Powered by Google App Engine
This is Rietveld 408576698