Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2288813002: GN: release -> -O3, to match GYP (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: release -> -O3, to match GYP -O3 does trigger some important compiler optimizations that -Os does not, like autovectorization. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288813002 Committed: https://skia.googlesource.com/skia/+/7957872f39f988d19793276680ae663da2d563fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gn/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
4 years, 3 months ago (2016-08-29 16:49:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288813002/1
4 years, 3 months ago (2016-08-29 16:49:29 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-08-29 16:49:31 UTC) #6
jcgregorio
lgtm
4 years, 3 months ago (2016-08-29 16:52:55 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 17:24:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7957872f39f988d19793276680ae663da2d563fe

Powered by Google App Engine
This is Rietveld 408576698