Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 22888008: Add V8_ALIGNOF() and use that in lazy-instance.h. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add V8_ALIGNOF() and use that in lazy-instance.h. Also fix the inconsistent attribute naming, and make V8_GNUC_PREREQ() test work for GCC compatible compilers. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16311

Patch Set 1 #

Patch Set 2 : Improve detection of __alignof__ in clang. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -25 lines) Patch
M include/v8config.h View 1 9 chunks +55 lines, -14 lines 0 comments Download
M src/lazy-instance.h View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Another trivial cleanup, PTAL.
7 years, 3 months ago (2013-08-26 06:18:14 UTC) #1
Sven Panne
lgtm
7 years, 3 months ago (2013-08-26 07:42:18 UTC) #2
Benedikt Meurer
7 years, 3 months ago (2013-08-26 08:06:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16311.

Powered by Google App Engine
This is Rietveld 408576698