Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 2288763002: a11y: add a11y title for bookmark chevron / "off the side button" (Closed)

Created:
4 years, 3 months ago by Elly Fong-Jones
Modified:
4 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

a11y: add a11y title for bookmark chevron / "off the side button" Before: VO reads "button" After: VO reads "Menu containing hidden bookmarks, button" BUG=641496 Committed: https://crrev.com/5a69355bda63ba06fe176616bba00d026ae368d0 Cr-Commit-Position: refs/heads/master@{#415088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Elly Fong-Jones
mark: ptal? :)
4 years, 3 months ago (2016-08-29 11:27:03 UTC) #3
Mark Mentovai
LGTM
4 years, 3 months ago (2016-08-29 14:33:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288763002/1
4 years, 3 months ago (2016-08-29 14:40:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/286525)
4 years, 3 months ago (2016-08-29 16:05:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288763002/1
4 years, 3 months ago (2016-08-29 16:37:22 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 04:22:00 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:23:22 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a69355bda63ba06fe176616bba00d026ae368d0
Cr-Commit-Position: refs/heads/master@{#415088}

Powered by Google App Engine
This is Rietveld 408576698