Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2288753002: [libfuzzer] Add "Symbolization" and "Debugging" sections to reproducing.md page. (Closed)

Created:
4 years, 3 months ago by mmoroz
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[libfuzzer] Add "Symbolization" and "Debugging" sections to reproducing.md page. R=aizatsky@chromium.org, inferno@chromium.org, ochang@chromium.org, thakis@chromium.org BUG=640967 Committed: https://crrev.com/03e2e556db0bd18809f75059d0fc1804324d0e82 Cr-Commit-Position: refs/heads/master@{#415014}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add llvm-symbolizer path in Chromium repo, fix grammar error, add abort_on_error for ASan. #

Patch Set 3 : Small grammar fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M testing/libfuzzer/reproducing.md View 1 2 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
mmoroz
4 years, 3 months ago (2016-08-29 10:47:27 UTC) #1
Nico
Thanks, this is very helpful. https://codereview.chromium.org/2288753002/diff/1/testing/libfuzzer/reproducing.md File testing/libfuzzer/reproducing.md (right): https://codereview.chromium.org/2288753002/diff/1/testing/libfuzzer/reproducing.md#newcode93 testing/libfuzzer/reproducing.md:93: make sure `llvm-symbolizer` is ...
4 years, 3 months ago (2016-08-29 12:04:13 UTC) #2
mmoroz
Thanks Nico for comments! https://codereview.chromium.org/2288753002/diff/1/testing/libfuzzer/reproducing.md File testing/libfuzzer/reproducing.md (right): https://codereview.chromium.org/2288753002/diff/1/testing/libfuzzer/reproducing.md#newcode93 testing/libfuzzer/reproducing.md:93: make sure `llvm-symbolizer` is in ...
4 years, 3 months ago (2016-08-29 12:40:00 UTC) #3
Nico
lgtm, thanks!
4 years, 3 months ago (2016-08-29 13:08:39 UTC) #4
inferno
lgtm
4 years, 3 months ago (2016-08-29 14:57:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288753002/40001
4 years, 3 months ago (2016-08-29 14:57:34 UTC) #7
Oliver Chang
lgtm
4 years, 3 months ago (2016-08-29 15:29:10 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-29 15:49:20 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 15:51:09 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/03e2e556db0bd18809f75059d0fc1804324d0e82
Cr-Commit-Position: refs/heads/master@{#415014}

Powered by Google App Engine
This is Rietveld 408576698