Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 22887053: Fix NaCl build after r16322. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M test/cctest/test-code-stubs.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Trivial fix for the NaCl build break.
7 years, 3 months ago (2013-08-26 13:21:44 UTC) #1
Michael Achenbach
LGTM
7 years, 3 months ago (2013-08-26 13:36:10 UTC) #2
Benedikt Meurer
Committed patchset #1 manually as r16327 (presubmit successful).
7 years, 3 months ago (2013-08-26 13:37:16 UTC) #3
Sven Panne
7 years, 3 months ago (2013-08-27 07:22:36 UTC) #4
Message was sent while issue was closed.
A bit late, but nevertheless: This should better use the helper functions/class
in double.h.

Powered by Google App Engine
This is Rietveld 408576698