Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: remoting/test/auth_browsertest.cc

Issue 22887025: Refactor remote_desktop_browsertest: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser_tests_a
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/test/launch_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/test/auth_browsertest.cc
diff --git a/remoting/test/auth_browsertest.cc b/remoting/test/auth_browsertest.cc
index 845a842f6e71b76ea589ad16f8214afcc3242774..51f464dc1b1ffae951a4fd76500bee6854584cd9 100644
--- a/remoting/test/auth_browsertest.cc
+++ b/remoting/test/auth_browsertest.cc
@@ -9,31 +9,14 @@ namespace remoting {
IN_PROC_BROWSER_TEST_F(RemoteDesktopBrowserTest, MANUAL_Auth) {
VerifyInternetAccess();
- if (!NoInstall()) {
- VerifyChromotingLoaded(false);
- InstallChromotingApp();
- }
-
- VerifyChromotingLoaded(true);
+ Install();
LaunchChromotingApp();
- Authorize();
-
- Authenticate();
-
- Approve();
-
- // TODO: Remove this hack by blocking on the appropriate notification.
- // The browser may still be loading images embedded in the webapp. If we
- // uinstall it now those load will fail. Navigating away to avoid the load
- // failures.
- ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
+ // Authorize, Authenticate, and Approve.
+ Auth();
garykac 2013/08/19 18:02:28 Perhaps AuthAuthAppApp? ^_^ For Authorize, Authen
- if (!NoCleanup()) {
- UninstallChromotingApp();
- VerifyChromotingLoaded(false);
- }
+ Cleanup();
}
} // namespace remoting
« no previous file with comments | « no previous file | remoting/test/launch_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698