Issue 22887025: Refactor remote_desktop_browsertest:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22887025: Refactor remote_desktop_browsertest: (Closed)

Created:
7 years, 4 months ago by weitao

Modified:
7 years, 4 months ago

Reviewers:
garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@browser_tests_a

Visibility:
Public.

More Reviews

Description

Refactor remote_desktop_browsertest: 1. Adding some helpers to perform common composite tasks. 2. Reorder methods to comply to chromium coding styles. 3. Move some functions defined inline to the .cc file. 4. Better comments and grouping of the class methods. BUG=134210 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218372

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+219 lines, -168 lines)			Patch
M	remoting/test/auth_browsertest.cc	View	1 chunk	+4 lines, -21 lines	1 comment	Download
M	remoting/test/launch_browsertest.cc	View	1 chunk	+2 lines, -16 lines	0 comments	Download
M	remoting/test/remote_desktop_browsertest.h	View	6 chunks	+57 lines, -69 lines	0 comments	Download
M	remoting/test/remote_desktop_browsertest.cc	View	4 chunks	+156 lines, -62 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

garykac

lgtm https://codereview.chromium.org/22887025/diff/1/remoting/test/auth_browsertest.cc File remoting/test/auth_browsertest.cc (right): https://codereview.chromium.org/22887025/diff/1/remoting/test/auth_browsertest.cc#newcode17 remoting/test/auth_browsertest.cc:17: Auth(); Perhaps AuthAuthAppApp? ^_^ For Authorize, Authenticate and ...

7 years, 4 months ago (2013-08-19 18:02:27 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/22887025/1

7 years, 4 months ago (2013-08-19 18:22:45 UTC) #3

Message was sent while issue was closed.

Change committed as 218372

Expand Messages | Collapse Messages