Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

Issue 22887015: Remove PerBrowser launcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/ash/launcher/launcher_context_menu.h" 5 #include "chrome/browser/ui/ash/launcher/launcher_context_menu.h"
6 6
7 #include "ash/launcher/launcher.h" 7 #include "ash/launcher/launcher.h"
8 #include "ash/launcher/launcher_model.h" 8 #include "ash/launcher/launcher_model.h"
9 #include "ash/launcher/launcher_types.h" 9 #include "ash/launcher/launcher_types.h"
10 #include "ash/test/ash_test_base.h" 10 #include "ash/test/ash_test_base.h"
11 #include "base/prefs/pref_service.h" 11 #include "base/prefs/pref_service.h"
12 #include "chrome/app/chrome_command_ids.h" 12 #include "chrome/app/chrome_command_ids.h"
13 #include "chrome/browser/prefs/incognito_mode_prefs.h" 13 #include "chrome/browser/prefs/incognito_mode_prefs.h"
14 #include "chrome/browser/profiles/profile.h" 14 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h" 15 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
16 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser. h" 16 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.h"
17 #include "chrome/test/base/testing_profile.h" 17 #include "chrome/test/base/testing_profile.h"
18 #include "ui/aura/root_window.h" 18 #include "ui/aura/root_window.h"
19 19
20 class TestChromeLauncherControllerPerBrowser : 20 class TestChromeLauncherControllerPerApp :
Mr4D (OOO till 08-26) 2013/08/16 22:43:22 Remove the "PerApp" here.
simonhong_ 2013/08/19 05:26:11 Done.
21 public ChromeLauncherControllerPerBrowser { 21 public ChromeLauncherControllerPerApp {
22 public: 22 public:
23 TestChromeLauncherControllerPerBrowser( 23 TestChromeLauncherControllerPerApp(
24 Profile* profile, ash::LauncherModel* model) 24 Profile* profile, ash::LauncherModel* model)
25 : ChromeLauncherControllerPerBrowser(profile, model) {} 25 : ChromeLauncherControllerPerApp(profile, model) {}
26 virtual bool IsLoggedInAsGuest() OVERRIDE { 26 virtual bool IsLoggedInAsGuest() OVERRIDE {
27 return false; 27 return false;
28 } 28 }
29 private: 29 private:
30 DISALLOW_COPY_AND_ASSIGN(TestChromeLauncherControllerPerBrowser); 30 DISALLOW_COPY_AND_ASSIGN(TestChromeLauncherControllerPerApp);
Mr4D (OOO till 08-26) 2013/08/16 22:43:22 Remove PerApp.
simonhong_ 2013/08/19 05:26:11 Done.
31 }; 31 };
32 32
33 class LauncherContextMenuTest : public ash::test::AshTestBase { 33 class LauncherContextMenuTest : public ash::test::AshTestBase {
34 protected: 34 protected:
35 static bool IsItemPresentInMenu(LauncherContextMenu* menu, int command_id) { 35 static bool IsItemPresentInMenu(LauncherContextMenu* menu, int command_id) {
36 DCHECK(menu); 36 DCHECK(menu);
37 return menu->GetIndexOfCommandId(command_id) != -1; 37 return menu->GetIndexOfCommandId(command_id) != -1;
38 } 38 }
39 39
40 LauncherContextMenuTest() 40 LauncherContextMenuTest()
41 : profile_(new TestingProfile()) {} 41 : profile_(new TestingProfile()) {}
42 42
43 virtual void SetUp() OVERRIDE { 43 virtual void SetUp() OVERRIDE {
44 ash::test::AshTestBase::SetUp(); 44 ash::test::AshTestBase::SetUp();
45 controller_.reset( 45 controller_.reset(
46 new TestChromeLauncherControllerPerBrowser(profile(), 46 new TestChromeLauncherControllerPerApp(profile(),
Mr4D (OOO till 08-26) 2013/08/16 22:43:22 Remove PerApp & indenting.
simonhong_ 2013/08/19 05:26:11 Done.
47 &launcher_model_)); 47 &launcher_model_));
48 } 48 }
49 49
50 virtual void TearDown() OVERRIDE { 50 virtual void TearDown() OVERRIDE {
51 controller_.reset(NULL); 51 controller_.reset(NULL);
52 ash::test::AshTestBase::TearDown(); 52 ash::test::AshTestBase::TearDown();
53 } 53 }
54 54
55 LauncherContextMenu* CreateLauncherContextMenu( 55 LauncherContextMenu* CreateLauncherContextMenu(
56 ash::LauncherItemType launcher_item_type) { 56 ash::LauncherItemType launcher_item_type) {
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 EXPECT_TRUE(menu->IsCommandIdEnabled(LauncherContextMenu::MENU_NEW_WINDOW)); 105 EXPECT_TRUE(menu->IsCommandIdEnabled(LauncherContextMenu::MENU_NEW_WINDOW));
106 106
107 // Disable Incognito mode. 107 // Disable Incognito mode.
108 IncognitoModePrefs::SetAvailability(profile()->GetPrefs(), 108 IncognitoModePrefs::SetAvailability(profile()->GetPrefs(),
109 IncognitoModePrefs::FORCED); 109 IncognitoModePrefs::FORCED);
110 menu.reset(CreateLauncherContextMenu(ash::TYPE_BROWSER_SHORTCUT)); 110 menu.reset(CreateLauncherContextMenu(ash::TYPE_BROWSER_SHORTCUT));
111 ASSERT_TRUE(IsItemPresentInMenu( 111 ASSERT_TRUE(IsItemPresentInMenu(
112 menu.get(), LauncherContextMenu::MENU_NEW_WINDOW)); 112 menu.get(), LauncherContextMenu::MENU_NEW_WINDOW));
113 EXPECT_FALSE(menu->IsCommandIdEnabled(LauncherContextMenu::MENU_NEW_WINDOW)); 113 EXPECT_FALSE(menu->IsCommandIdEnabled(LauncherContextMenu::MENU_NEW_WINDOW));
114 } 114 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698