Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2288683002:
Hide WrapUnique() -> MakeUnique() change from blame (Closed)
|
Created:
4 years, 3 months ago by Adam Rice Modified:
4 years, 3 months ago Reviewers:
Matt Giuca CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionHide WrapUnique() -> MakeUnique() change from blame
There are a large number of mechanical changes of usages of WrapUnique()
to MakeUnique(). The blame information for these is not useful as it
does not reflect the people responsible for the code.
Add the relevant commits to .git-blame-ignore-revs so that they will be
skipped by git hyper-blame.
R=mgiuca@chromium.org
BUG=637812
Committed: https://crrev.com/5958170d51988d8dcf087e48e42beab44bb1a066
Cr-Commit-Position: refs/heads/master@{#418833}
Patch Set 1 #Patch Set 2 : Add remaining CLs to ignore list #Patch Set 3 : Add commits in oldest to newest order. #Messages
Total messages: 21 (11 generated)
The CQ bit was checked by ricea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Hide WrapUnique() -> MakeUnique() change from blame There are a large number of mechanical changes of usages of WrapUnique() to MakeUnique(). The blame information for these is not useful as it does not reflect the people responsible for the code. Add the relevant commits to .git-blame-ignore-revs so that they will be skipped by git hyper-blame. There are still some straggler CLs that have not yet been lgtm'd by all owners or made it through the CQ, but those can be added later. R=mguica@chromium.org BUG= ========== to ========== Hide WrapUnique() -> MakeUnique() change from blame There are a large number of mechanical changes of usages of WrapUnique() to MakeUnique(). The blame information for these is not useful as it does not reflect the people responsible for the code. Add the relevant commits to .git-blame-ignore-revs so that they will be skipped by git hyper-blame. There are still some straggler CLs that have not yet been lgtm'd by all owners or made it through the CQ, but those can be added later. R=mgiuca@chromium.org BUG= ==========
mgiuca@chromium.org changed reviewers: + mgiuca@chromium.org - mguica@chromium.org
-mguica +mgiuca :)
These all look good (I skimmed through all the CLs). But you mentioned some "straggler CLs" that haven't quite landed yet. In the interest of avoiding churn, I'd like to hold off on landing this until those stragglers land, assuming they'll take < a few days. lgtm though, if you think it will take longer than that, feel free to land this and update later.
On 2016/08/30 07:55:52, Matt Giuca wrote:
> These all look good (I skimmed through all the CLs). But you mentioned some
> "straggler CLs" that haven't quite landed yet. In the interest of avoiding
> churn, I'd like to hold off on landing this until those stragglers land,
> assuming they'll take < a few days.
>
> lgtm though, if you think it will take longer than that, feel free to land
this
> and update later.
I usually manage to land a few stragglers per day. But each one takes longer
than
the last.
I will leave the command I need to generate the list here to remind myself in
case
it takes months to get the last ones landed:
git rev-list --grep 'Re-write many calls to WrapUnique() with MakeUnique()' \
--author=ricea@chromium.org HEAD
mgiuca, I've landed everything now. PTAL.
Hi Adam. lgtm but please reorder them in chronological order from top to bottom (earliest to latest), as per the instructions at the top of the file. These appear to be in reverse order.
Description was changed from ========== Hide WrapUnique() -> MakeUnique() change from blame There are a large number of mechanical changes of usages of WrapUnique() to MakeUnique(). The blame information for these is not useful as it does not reflect the people responsible for the code. Add the relevant commits to .git-blame-ignore-revs so that they will be skipped by git hyper-blame. There are still some straggler CLs that have not yet been lgtm'd by all owners or made it through the CQ, but those can be added later. R=mgiuca@chromium.org BUG= ========== to ========== Hide WrapUnique() -> MakeUnique() change from blame There are a large number of mechanical changes of usages of WrapUnique() to MakeUnique(). The blame information for these is not useful as it does not reflect the people responsible for the code. Add the relevant commits to .git-blame-ignore-revs so that they will be skipped by git hyper-blame. R=mgiuca@chromium.org BUG=637812 ==========
On 2016/09/15 08:48:46, Matt Giuca wrote: > Hi Adam. lgtm but please reorder them in chronological order from top to bottom > (earliest to latest), as per the instructions at the top of the file. These > appear to be in reverse order. Sorry about that. I have fixed it.
The CQ bit was checked by ricea@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mgiuca@chromium.org Link to the patchset: https://codereview.chromium.org/2288683002/#ps40001 (title: "Add commits in oldest to newest order.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Hide WrapUnique() -> MakeUnique() change from blame There are a large number of mechanical changes of usages of WrapUnique() to MakeUnique(). The blame information for these is not useful as it does not reflect the people responsible for the code. Add the relevant commits to .git-blame-ignore-revs so that they will be skipped by git hyper-blame. R=mgiuca@chromium.org BUG=637812 ========== to ========== Hide WrapUnique() -> MakeUnique() change from blame There are a large number of mechanical changes of usages of WrapUnique() to MakeUnique(). The blame information for these is not useful as it does not reflect the people responsible for the code. Add the relevant commits to .git-blame-ignore-revs so that they will be skipped by git hyper-blame. R=mgiuca@chromium.org BUG=637812 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Hide WrapUnique() -> MakeUnique() change from blame There are a large number of mechanical changes of usages of WrapUnique() to MakeUnique(). The blame information for these is not useful as it does not reflect the people responsible for the code. Add the relevant commits to .git-blame-ignore-revs so that they will be skipped by git hyper-blame. R=mgiuca@chromium.org BUG=637812 ========== to ========== Hide WrapUnique() -> MakeUnique() change from blame There are a large number of mechanical changes of usages of WrapUnique() to MakeUnique(). The blame information for these is not useful as it does not reflect the people responsible for the code. Add the relevant commits to .git-blame-ignore-revs so that they will be skipped by git hyper-blame. R=mgiuca@chromium.org BUG=637812 Committed: https://crrev.com/5958170d51988d8dcf087e48e42beab44bb1a066 Cr-Commit-Position: refs/heads/master@{#418833} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/5958170d51988d8dcf087e48e42beab44bb1a066 Cr-Commit-Position: refs/heads/master@{#418833} |
