Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2288663002: Enable Quick View on file selector / file download window. (Closed)

Created:
4 years, 3 months ago by oka
Modified:
4 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable Quick View on file selector / file download window. BUG=641617 TEST=manually tested. Committed: https://crrev.com/3161c433a2fee484834a3c587e6d3ed111934f64 Cr-Commit-Position: refs/heads/master@{#415106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 2 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
oka
PTAL.
4 years, 3 months ago (2016-08-29 07:06:37 UTC) #2
fukino
lgtm
4 years, 3 months ago (2016-08-29 08:12:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288663002/1
4 years, 3 months ago (2016-08-30 02:09:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 04:40:23 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 04:43:55 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3161c433a2fee484834a3c587e6d3ed111934f64
Cr-Commit-Position: refs/heads/master@{#415106}

Powered by Google App Engine
This is Rietveld 408576698