third_party/WebKit/Source/build/scripts/templates/ElementFactory.h.tmpl - Issue 2288653002: Make custom element name checks faster and fewer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ElementFactory.h.tmpl

Issue 2288653002: Make custom element name checks faster and fewer (Closed)

Patch Set: Lift the is8Bit check. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp ('K') | « third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElement.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/ElementFactory.h.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/ElementFactory.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/ElementFactory.h.tmpl

index 6b47f18e121fff6c42ed956dd315c17a8973535b..2cbcd6fd3c58a1bb9865afd453ead4b9b7e40603 100644

--- a/third_party/WebKit/Source/build/scripts/templates/ElementFactory.h.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/ElementFactory.h.tmpl

@@ -14,6 +14,7 @@ namespace blink {

class Document;

class {{namespace}}Element;

{% if namespace == 'HTML' %}

+class ExceptionState;

class HTMLFormElement;

{% endif %}

@@ -24,6 +25,7 @@ public:

Document&,

{% if namespace == 'HTML' %}

HTMLFormElement* = 0,

+ ExceptionState* = 0,

kouhei (in TOK) 2016/08/29 06:59:55 nullptr

{% endif %}

CreateElementFlags flags = CreatedByParser);

};