Make custom element name checks faster and fewer

third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
index 31d565d79308d7a30a43ee0825152e28d73b32ce..b09c8141c9965a544e300d11d6fd7735e6ba5304 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h
@@ -44,8 +44,7 @@ public:
     v8::Local<v8::Object> constructor() const;
     v8::Local<v8::Object> prototype() const;
 
-    HTMLElement* createElementSync(Document&, const QualifiedName&) override;
-    HTMLElement* createElementSync(Document&, const QualifiedName&, ExceptionState&) override;
+    HTMLElement* createElementSync(Document&, const QualifiedName&, ExceptionState*) override;
 
     bool hasConnectedCallback() const override;
     bool hasDisconnectedCallback() const override;
@@ -69,6 +68,9 @@ private:
         const v8::Local<v8::Function>& attributeChangedCallback,
         const HashSet<AtomicString>& observedAttributes);
 
+    HTMLElement* createElementSync(Document&, const QualifiedName&);
+    HTMLElement* createElementSync(Document&, const QualifiedName&, ExceptionState&);

[esprehn, 2016/08/30 21:32:32]

I think I'd give these different names? Having this method which is the same as
the virtual above is confusing.

+
     // Implementations of |CustomElementDefinition|
     ScriptValue getConstructorForScript() final;
     bool runConstructor(Element*) override;