third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp - Issue 2288633002: Recognise variable names when parsing CSS property names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp

Issue 2288633002: Recognise variable names when parsing CSS property names (Closed)

Patch Set: fix long var names Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp

diff --git a/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp b/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp

index c82875cb07b2c0a79ac120fa478163461b4ebfed..64452da2d77fcc5b7c3eb4f04488091d487ac31d 100644

--- a/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp

+++ b/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.cpp

@@ -21,7 +21,8 @@ ScriptValue CSSStyleValue::parse(ScriptState* scriptState, const String& propert

}

CSSPropertyID propertyID = cssPropertyID(propertyName);

- if (propertyID == CSSPropertyInvalid) {

+ // TODO(timloh): Handle custom properties

+ if (propertyID == CSSPropertyInvalid || propertyID == CSSPropertyVariable) {

exceptionState.throwTypeError("Invalid property name");

return ScriptValue::createNull(scriptState);

}