Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2288613002: ServiceWorker: Enable CHECK to confirm crash doesn't happen (Closed)

Created:
4 years, 3 months ago by shimazu
Modified:
4 years, 3 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Enable CHECK to confirm crash doesn't happen This patch is to confirm crashes are gone. BUG=634222 Committed: https://crrev.com/afb2f14ceb5456b460770434f19ea690430b8a68 Cr-Commit-Position: refs/heads/master@{#415859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/service_worker/service_worker_provider_host.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
shimazu
ptal
4 years, 3 months ago (2016-08-29 02:06:25 UTC) #2
nhiroki
lgtm
4 years, 3 months ago (2016-08-29 02:08:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288613002/1
4 years, 3 months ago (2016-08-29 04:45:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/283038)
4 years, 3 months ago (2016-08-29 06:02:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288613002/1
4 years, 3 months ago (2016-08-31 23:57:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 02:39:45 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 02:40:59 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/afb2f14ceb5456b460770434f19ea690430b8a68
Cr-Commit-Position: refs/heads/master@{#415859}

Powered by Google App Engine
This is Rietveld 408576698