Bugfix in gclient_scm.py: Remove the correct directories if svn checkout is in a broken state

gclient_scm.py

Index: gclient_scm.py
diff --git a/gclient_scm.py b/gclient_scm.py
index af74b754d187d37ae87d7c26c1b0cff4c670cd81..ab397987c62256b890cbbf4d4c2ffa5890e49306 100644
--- a/gclient_scm.py
+++ b/gclient_scm.py
@@ -1230,8 +1230,13 @@ class SVNWrapper(SCMWrapper):
         for d in dir_info:
           if d[0][2] == 'L':
             if d[0][0] == '!' and options.force:
-              print 'Removing troublesome path %s' % d[1]
-              gclient_utils.rmtree(d[1])

[kustermann, 2013/08/14 12:12:55]

We call 'scm.SVN.CaptureStatus()' with cwd=self.checkout_path. Which will just
call '$ svn status ...' inside cwd. The reported paths will be relative to cwd.
For example: 

$ svn status | head
! L     .
! L     3.8.2
! L     3.8.2/plugins
  L     3.7.0
  L     3.7.0/plugins

Then we call 'gclient_utils.rmtree(d[1])'. This will potentially delete the
wrong directories.

In the above example we will remove '.'! So we need to do
'os.path.join(self.checkout_path, d[1]).

+              if os.path.isabs(d[1]):

[kustermann, 2013/08/14 12:12:55]

AFAIK "d[1]" will always be relative. I added this just to double check.

[iannucci, 2013/08/15 19:28:18]

Maybe since we don't expect this path to hit at all, just `assert not
os.path.isabs(d[1])` ?

Makes me nervous to support conditions which we have no way to observe/test....

[kustermann, 2013/08/19 07:29:34]

Done.

+                path_to_remove = d[1]
+              else:
+                path_to_remove = os.path.normpath(
+                    os.path.join(self.checkout_path, d[1]))
+              print 'Removing troublesome path %s' % path_to_remove
+              gclient_utils.rmtree(path_to_remove)
             else:
               print 'Not removing troublesome path %s automatically.' % d[1]
               if d[0][0] == '!':