Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2288593005: Revert "Update co19 to revision d4767b4caea3c5828ad8e053cd051d44a59061af" (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Update co19 to revision d4767b4caea3c5828ad8e053cd051d44a59061af" This reverts commit a829cfff4b99d0cea250b8121eae1bf5430bc3db. The co19 update often introduces many test failures, even after testing locally and updating status files. So we may revert the update, after seeing which tests are failing on the buildbot, to do more updates on the status files before landing again. BUG=https://github.com/dart-lang/sdk/issues/27162 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/792997c347fceaa9c27c736c3fe027fd7d2635a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+400 lines, -507 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-analyzer2.status View 5 chunks +361 lines, -456 lines 0 comments Download
M tests/co19/co19-co19.status View 2 chunks +1 line, -10 lines 0 comments Download
M tests/co19/co19-dart2js.status View 17 chunks +30 lines, -30 lines 0 comments Download
M tests/co19/co19-runtime.status View 3 chunks +6 lines, -9 lines 0 comments Download
M tools/deps/dartium.deps/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
4 years, 3 months ago (2016-08-29 15:53:47 UTC) #1
floitsch
LGTM.
4 years, 3 months ago (2016-08-29 15:54:12 UTC) #2
Bill Hesse
4 years, 3 months ago (2016-08-29 16:57:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
792997c347fceaa9c27c736c3fe027fd7d2635a8.

Powered by Google App Engine
This is Rietveld 408576698